Opened 11 years ago

Closed 11 years ago

#41 closed task (fixed)

Upgrade CF checker to CF-1.3

Reported by: ros Owned by: ros
Priority: medium Milestone:
Component: cf-checker Version: 1.3
Keywords: UPGRADE, FLAGS Cc:

Description

CF-1.3 additional requirements include:

Section 3.5 Flags
Requirements:

  • The flag_values attribute must have the same type as the variable to which it is attached.
  • The number of flag_values attribute values must equal the number of words or phrases appearing in the flag_meanings string.
  • The number of flag_masks attribute values must equal the number of words or phrases appearing in the flag_meanings string.
  • Variables with a flag_masks attribute must have a type that is compatible with bit field expression (char, byte, short and int), not floating-point (float, real, double), and the flag_masks attribute must have the same type.
  • The flag_masks attribute values must be non-zero.
  • The flag_values attribute values must be mutually exclusive among the set of flag_values attribute values defined for that variable.

Recommendations:

  • When flag_masks and flag_values are both defined, the Boolean AND of each entry in flag_values with its corresponding entry in flag_masks should equal the flag_values entry, ie, the mask selects all the bits required to express the value.

Change History (2)

comment:1 Changed 11 years ago by ros

  • Owner changed from cf-checker@… to ros
  • Status changed from new to assigned

Requirements: 1,2,3,5,6 and Recommendation: 1 implemented at r84

CF Checker version number changed to 1.3.0 where the first 2 digits match the CF Convention version. Modifications and fixes will result in an increment the third digit.

Whilst attempting to implement requirement:4 I feel that having a flag_masks attribute for a char variable doesn't really make sense especially when the recommendation check is considered. Will raise this on the mailing list before I continue with implementing this check.

comment:2 Changed 11 years ago by ros

  • Resolution set to fixed
  • Status changed from assigned to closed

Version 1.3.0 released. r95

CF Checker @Reading updated and update requested on the BADC site.

Note: See TracTickets for help on using tickets.